Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsdoc): controlText_ should have a protected access modifier. #7972

Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix(jsdoc): controlText_ should have a protected access modifier. #7972

merged 1 commit into from
Oct 28, 2022

Conversation

gjanblaszczyk
Copy link
Member

Description

The controlText_ property should have a protected access modifier.
The PR is related to #7971

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #7972 (e1e6425) into next (fa57723) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #7972      +/-   ##
==========================================
- Coverage   81.95%   81.94%   -0.02%     
==========================================
  Files         110      110              
  Lines        7333     7333              
  Branches     1767     1767              
==========================================
- Hits         6010     6009       -1     
- Misses       1323     1324       +1
Impacted Files Coverage Δ
src/js/big-play-button.js 27.58% <ø> (ø)
src/js/clickable-component.js 90.00% <ø> (ø)
...rol-bar/audio-track-controls/audio-track-button.js 87.50% <ø> (ø)
src/js/control-bar/fullscreen-toggle.js 94.11% <ø> (ø)
src/js/control-bar/mute-toggle.js 94.59% <ø> (ø)
src/js/control-bar/picture-in-picture-toggle.js 79.31% <ø> (ø)
src/js/control-bar/play-toggle.js 84.84% <ø> (ø)
...ar/playback-rate-menu/playback-rate-menu-button.js 100.00% <ø> (ø)
src/js/control-bar/seek-to-live.js 92.85% <ø> (ø)
...control-bar/text-track-controls/captions-button.js 81.25% <ø> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gjanblaszczyk gjanblaszczyk merged commit 9e7b681 into next Oct 28, 2022
@gjanblaszczyk gjanblaszczyk deleted the fix/protected-controltext branch October 28, 2022 07:15
misteroneill pushed a commit that referenced this pull request Nov 23, 2022
@gjanblaszczyk @misteroneill
fix(jsdoc): controlText_ should have a protected access modifier. (#7972
85c2b0c 
)
misteroneill pushed a commit that referenced this pull request Nov 23, 2022
@gjanblaszczyk @misteroneill
fix(jsdoc): controlText_ should have a protected access modifier. (#7972
dec7075 
)
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
@gjanblaszczyk @edirub
fix(jsdoc): controlText_ should have a protected access modifier. (vi…
92ec40d 
…deojs#7972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mister-ben mister-ben mister-ben approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjanblaszczyk @gkatsev @mister-ben